Task validation fixes and rewrites (by Steampunk Spotter) #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
These changes will try to correct one error and multiple hints within Ansible tasks I have encountered when running some checks with Steampunk Spotter.
Enhancements:
The first change fixes the following error detected by the Spotter CLI:
I also used Spotter's rewrite feature (
--rewrite
) to correct a bad practice of inline passing of parameters to modules and replaced that with exact parameters.How has this been tested?:
N/A
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A